Bug #1382

javascript as link in treenode doen'st work

Details

Submitted	2004-05-11 11:36 UTC
From	jmourot at sdis69 dot fr
Status	Bogus
Package	HTML_TreeMenu
PHP Version	4.3.6
OS	w2k
Roadmaps	(Not assigned)

Comments

[2004-05-11 11:36 UTC] jmourot at sdis69 dot fr

Description:
------------
When adding a javascript function with quotes as a link for a treenode item there is a javascript error

It seems it could be solved by replacing single quote with double quote when generating the HTML code

Reproduce code:
---------------
In TreeMenu.php
function _nodeToHTML($nodeObj, $prefix, $return = 'newNode', $currentDepth = 0, $maxDepthPrefix = null)
{
[......]

Replace single quote by double quote :
// !empty($nodeObj->link) ? "'" . $nodeObj->link . "'" : 'null',
!empty($nodeObj->link) ? "\"" . $nodeObj->link . "\"" : 'null',

Expected result:
----------------
newNode = objTreeMenu_1.addItem(new TreeNode('Some item', 'folder.gif', "javascript:fwk_action('lien','/somepage.php?mode=view&idstruct=226&SessID=pm0217836001084275566");', false, true, '', '', 'folder-expanded.gif'));

Actual result:
--------------
newNode = objTreeMenu_1.addItem(new TreeNode('Some item', 'folder.gif', 'javascript:fwk_action('lien','/somepage.php?mode=view&idstruct=226&SessID=pm0217836001084275566');', false, true, '', '', 'folder-expanded.gif'));