Bug #1885

join(order, wrong)

Details

Submitted	2004-07-15 20:04 UTC
From	hlarue at columbus dot rr dot com
Status	Bogus
Package	Auth
PHP Version	Irrelevant
OS	Irrelevant
Roadmaps	(Not assigned)

Comments

[2004-07-15 20:04 UTC] hlarue at columbus dot rr dot com

Description:
------------
Line 194 of DB.php v1.4.5 (and other files/versions ?) join(y, x)'s the 'db_fields' option with the parameters in the wrong order.

Reproduce code:
---------------
$this->options['db_fields'] =
join($this->options['db_fields'], ', ');

...should be:

$this->options['db_fields'] =
join(', ', $this->options['db_fields']);

[2004-07-15 20:06 UTC] hlarue at columbus dot rr dot com

Nevermind...sorry...

Note: implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.

[2004-07-15 22:24 UTC] hlarue at columbus dot rr dot com

Closing...