Bug #1980

Logic error in joinAdd method

Details

Submitted	2004-07-26 14:01 UTC
From	P dot Kirov at bg dot forsythpartners dot com
Assigned	alan_k
Status	Closed
Package	DB_DataObject
PHP Version	4.3.2
OS	Linux 2.6.5
Roadmaps	(Not assigned)

Comments

[2004-07-26 14:01 UTC] P dot Kirov at bg dot forsythpartners dot com

Description:
------------
if ($quoteIdentifiers) {
$joinAs = $DB->quoteIdentifier($joinAs);
$table = $DB->quoteIdentifier($table);
$ofield = $DB->quoteIdentifier($ofield);
$tfield = $DB->quoteIdentifier($tfield);
}

$fullJoinAs = '';
if ( $DB->quoteIdentifier($obj->__table) != $joinAs) {
$fullJoinAs = "AS {$joinAs}";
}

Reproduce code:
---------------
if ($quoteIdentifiers) {
$joinAs = $DB->quoteIdentifier($joinAs);
$table = $DB->quoteIdentifier($table);
$ofield = $DB->quoteIdentifier($ofield);
$tfield = $DB->quoteIdentifier($tfield);
}

$fullJoinAs = '';
if ($obj->__table != $joinAs) {
$fullJoinAs = "AS {$joinAs}";
}