Bug #1991

Output is not W3C compliant (</li> missing!)

Details

Submitted	2004-07-27 10:25 UTC
From	thomas dot moulard at wanadoo dot fr
Assigned	blindman
Status	Closed
Package	Text_Highlighter
PHP Version	4.3.3
OS	windows XP
Roadmaps	(Not assigned)

Comments

[2004-07-27 10:25 UTC] thomas dot moulard at wanadoo dot fr

Description:
------------
* if highlighter is called with these options: array('numbers'=>false), the output is W3C compliant

* if highlighter is called with numbers set to true, the output is bad:

- </li> are missing at the end of the lines
- the <pre> (or <code>) tags should be IN each list items (not W3C compliant!

From the W3C validator:
Line 6, column 24: document type does not allow element "pre" here; assuming missing "li" start-tag

Line 6, column 28: document type does not allow element "li" here

Reproduce code:
---------------
<?php
require_once 'Text/Highlighter.php';
$hlSQL =& Text_Highlighter::factory('SQL',array('numbers'=>true));
echo $hlSQL->highlight('SELECT * FROM table a WHERE id = 12;');
?>

Expected result:
----------------
<ol class="hl-main">

<li> <pre>SELECT * FROM table a WHERE id = 12;</pre></li>

</ol>

Actual result:
--------------
<ol class="hl-main"><pre>
<li> SELECT * FROM table a WHERE id = 12;</pre></ol>