Home » Mail » Mail_Mime » Bug #2311
Method modification needed
Details
| Submitted | 2004-09-10 13:25 UTC |
|---|---|
| From | geels at datainlife dot ru |
| Assigned | sean |
| Status | Closed |
| Package | Mail_Mime |
| PHP Version | Irrelevant |
| OS | irrelevant |
| Roadmaps | (Not assigned) |
Comments
[2004-09-10 13:25 UTC] geels at datainlife dot ru
Description:
------------
Mail_mime::addHTMLImage()'s parameter 'name' works like described in documentation, only if first parameter contains file data.
But this is not very useful: if file is uploaded, first parameter is it's temporary name and parameter name may contain actual file name.
So it should work like Mail_mime::addAttachment()'s parameter 'name': always take new filename, if it's specified.
Workaround is to rename file using move_uploaded_file() before attaching.
Reproduce code:
---------------
This is second string from Mail_mime::addHTMLImage()
...
$filename = ($isfilename === true) ? $basename($file) : $basename($name);
...
This is from Mail_mime::addAttachment()
...
if ($isfilename === true) {
// Force the name the user supplied, otherwise use $file
$filename = (!empty($name)) ? $name : $file;
} else {
$filename = $name;
}
...
Expected result:
----------------
I've expected to recieve HTML message with inline image, named e.g. image1.gif.
Message text contains <img src="image1.gif">, I've attached file 'image1.gif' via web-form (I didn't call move_uploaded_file()) & sent message.
Actual result:
--------------
Message, that I recieved contains inline file with name 'php<some random value>' and its text contains <img src="image1.gif">. So image isn't shown in its place.
[2004-10-07 14:53 UTC] abajur at gmail dot com
Hey!!! It worked greeeat for me.
Using PHP 4.3.8 on Win2k Server under Apache 2.x
Thx!