Bug #2455

A patch to replace fpassthru() in HTTP_WebDAV_Server due to memory issues

Details

Submitted	2004-10-05 06:51 UTC
From	alex at waste dot me dot uk
Assigned	hholzgra
Status	Duplicate
Package	HTTP_WebDAV_Server
PHP Version	4.3.8
OS	All
Roadmaps	(Not assigned)

Comments

[2004-10-05 06:51 UTC] alex at waste dot me dot uk

Description:
------------
This patch revolves is poor memory performance due to
the use of fpassthru(). I've added a member function
called _send_stream(resource handle) that buffers the
output to the webdav client and replaces the fpassthru()
calls.

This makes noticeable improvements when large files are
being downloaded concurrently.

A URL to the patch is here:

http://projects.alexyoung.org/HTTP_WebDAV_Server.diff

[2004-10-05 14:05 UTC] schlueter at phpbar dot de

I didn't test your patch but one comment:

+ // TODO: This class needs more PEAR error reporting
+ PEAR::raiseError("error opening file");
+ return;

Currently HTTP_WebDAV_Server works completly without other PEAR stuff which makes installation and usage really simple. I would like to keep it this way.