Bug #2512

When using a custom valueColumn no pref ever returned

Details

Submitted	2004-10-12 07:42 UTC
From	aashley at optimiser dot com
Assigned	jellybob
Status	Closed
Package	Auth_PrefManager
PHP Version	5.0.2
OS	All
Roadmaps	(Not assigned)

Comments

[2004-10-12 07:42 UTC] aashley at optimiser dot com

Description:
------------
When using a custom valueColumn the valueColumn string is stored in a form quoted for using in SQL statements.

This makes it impossible for line 209 to retrieve the value from the returned array.

My patch to fix this stores the valueColumn as the original valueColumn (Auth_PrefManager::_valueColumn) and the quoted valueColumn (Auth_PrefManager::_valueColumnQuote). I chose to do it this way to minimise the number of function calls needed for setting and deleting preferences.

This could just as easily be done to store only the original version and quote it as needed.

Patch is available at: http://frood.cernun.net/stuff/PrefManager-custom-valueColumn.patch

[2004-11-07 20:15 UTC] jellybob at gmail dot com

Thank you for the patch, I'll apply it to CVS sometime soon and then make a new relase.