Bug #2534

ITDynamic does not allow empty group separators

Details

Submitted	2004-10-15 12:43 UTC
From	marian at kisd dot de
Assigned	avb
Status	Closed
Package	HTML_QuickForm
PHP Version	Irrelevant
Roadmaps	(Not assigned)

Comments

[2004-10-15 12:43 UTC] marian at kisd dot de

Description:
------------
I was trying to create groups of form elements with the ITDynamic renderer, using very exact layout of the form elements. Although I set the group seperator to null or '', there was always a between elements, resulting in empty lines in my layout.

I consider this a bug. A fix is attached below.

Reproduce code:
---------------
--- ITDynamic.php.orig 2004-10-15 14:10:35.000000000 +0200
+++ ITDynamic.php 2004-10-15 14:10:40.000000000 +0200
@@ -191,7 +191,7 @@
$blockName = $this->_matchBlock($group);
$this->_tpl->setCurrentBlock($blockName . '_loop');
$this->_groupElementIdx = 0;
- $this->_groupSeparator = empty($group->_separator)? ' ': $group->_separator;
+ $this->_groupSeparator = isset($group->_separator) ? '' : $group->_separator;
// show an '*' near the required element
if ($required) {
$this->_showRequired = true;