Bug #2568

LiveUser_Admin::setAdminAuthContainer() returns true on failure

Details

Submitted	2004-10-19 13:20 UTC
From	michael dot caplan at lechateau dot ca
Assigned	arnaud
Status	Closed
Package	LiveUser
PHP Version	Irrelevant
OS	irrelevant
Roadmaps	(Not assigned)

Comments

[2004-10-19 13:20 UTC] michael dot caplan at lechateau dot ca

Description:
------------
if LiveUser_Admin::_authFactory() fails, LiveUser_Admin::setAdminAuthContainer() still returns true. A simple:

if (PEAR::isError($this->_authContainers[$authName]) {
return false;
}

shoudl do the trick.

[2004-10-19 13:27 UTC] michael dot caplan at lechateau dot ca

in addition, LiveUser_Admin::setAdminContainers() doesn't trickle down the errors. Something like this should be happening:

if (isset($authName)) {
if (!isset($this->perm) || !is_object($this->perm)) {
$perm_res = $this->setAdminPermContainer();
}
$auth_res = $this->setAdminAuthContainer($authName);
return (!$perm_res || !$auth_res) ? false : true;
}