Home » Database » DB_DataObject_FormBuilder » Bug #3042
auto-detection based validation harmful
Details
| Submitted | 2004-12-27 20:52 UTC |
|---|---|
| From | andrew dot clark at ucsb dot edu |
| Assigned | justinpatrin |
| Status | Closed |
| Package | DB_DataObject_FormBuilder |
| PHP Version | 4.3.10 |
| OS | FreeBSD 4.10 |
| Roadmaps | (Not assigned) |
Comments
[2004-12-27 20:52 UTC] andrew dot clark at ucsb dot edu
Description:
------------
DO_FormBuilder tries to guess validation rules, but overrides rules added to form (through postGenerateForm, for example).
For integer types that are not integers in the form (IP address converted from dotted decimal to long notation, for example), this is harmful.
Here's the affected code in FormBuilder.php:
// Auto-detect field types depending on field's database type
switch (true) {
case ($type & DB_DATAOBJECT_INT):
if (!isset($element)) {
$element =& $this->_createIntegerField($key);
}
$elValidator = 'numeric';