Bug #3319

date format overrides timeformat

Details

Submitted	2005-01-28 01:03 UTC
From	wabut at yahoo dot com
Assigned	justinpatrin
Status	Closed
Package	DB_DataObject_FormBuilder
PHP Version	5.0.3
OS	Win XP
Roadmaps	(Not assigned)

Comments

[2005-01-28 01:03 UTC] wabut at yahoo dot com

Description:
------------
If you set both a $fb_dateformat and $fb_timeformat in your dataobject, the $fb_dateformat will be used on any element set in $fb_timeFields.

resolution:
in FormBuilder.php swap the order of these case statements

case ($type & (DB_DATAOBJECT_DATE | DB_DATAOBJECT_TIME)):
case ($type & DB_DATAOBJECT_TIME):

so that "case ($type & DB_DATAOBJECT_TIME):" is checked first.

Reproduce code:
---------------
/* in dataobject */
var $fb_dateElementFormat = "m/d/Y";
var $fb_timeElementFormat = "H:i";

var $fb_dateFields = array("datestart", "dateend");
var $fb_timeFields = array("timestart", "timeend");

/* in app */
$fg =& DB_DataObject_FormBuilder::create($DATAOBJECT);
$form =& $fg->getForm();
$form->accept($renderer);
$smarty->assign('form', $form->toHtml());

Expected result:
----------------
dates will appear as m/d/y
times will appear as H:i

Actual result:
--------------
dates appear as m/d/y
times appear as m/d/y