Bug #344

SQL compatibility suggestions

Details

Submitted	2003-12-03 19:52 UTC
From	anon at anon dot com
Assigned	arnaud
Status	Closed
Package	LiveUser
PHP Version	4.3.3
OS	ANY
Roadmaps	(Not assigned)

Comments

[2003-12-03 19:52 UTC] anon at anon dot com

Description:
------------
Suggest changing all DB SQL queries to use more database independent table aliases [referrences].

All queries should be changed from

SELECT {ALIAS}.* FROM {TABLENAME} AS {ALIAS}

SELECT {ALIAS}.* FROM {TABLENAME} {ALIAS}

The use of "AS" for creating table aliases is not supported in oracle, however the latter is confirmed supported in mysql, oracle, postgres, and mssql.

Also, the field "comment" in table LIVEUSER_TRANSLATIONS should be changed to "comments", since "comment" is a reserved word in oracle.

[2003-12-08 21:01 UTC] anon at anon dot com

Found one more that needs changing...

Admin/Perm/Container/DB_Complex.php:476

$query .= ' ' . $this->prefix . 'groups as groups,

should be

$query .= ' ' . $this->prefix . 'groups groups,

[2003-12-18 01:52 UTC] anon at anon dot com

Found one more that needs changing...

Perm/Container/DB_Medium.php:231 and
Perm/Container/DB_Medium.php:233