Bug #4127

Patch that fixes bugs 1016, 1077, 1358, 2834

Details

Request #4127	Patch that fixes bugs 1016, 1077, 1358, 2834
Submitted	2005-04-12 14:48 UTC
From	roehr at zilleon dot com
Assigned	troehr
Status	Closed
Package	HTTP_Session
PHP Version	Irrelevant
OS	Irrelevant
Roadmaps	(Not assigned)

Comments

[2005-04-12 14:48 UTC] roehr at zilleon dot com

Description:
------------
Hi,

I have created a patch that fixes the following open bugs:
1016 - Error on GC
1077 - Session expires before the expected time
1358 - Package doesn't overwrite expired sessions in DB
2834 - Unable to handle start() call after destroy() using DB container

The diffs can be found here:
http://www.zilleon.de/PEAR/HTTP/Session.diff.txt
http://www.zilleon.de/PEAR/HTTP/docs/HTTP_Session_Example.diff.txt
http://www.zilleon.de/PEAR/HTTP/Session/Container/DB.diff.txt

The patch will also introduce new wrapper methods for three ini settings:
HTTP_Session::useTransSID()
HTTP_Session::setGcMaxLifetime()
HTTP_Session::setGcProbability()

I hope this will provoke a new release. The last realese is from 2003-03-08!!!

Thanks for having a look.

Best regards,
Torsten Roehr

[2005-04-22 20:17 UTC] roehr at zilleon dot com

Hi Helgi,

thanks for having a look. I didn't introduce the $GLOBALS['HTTP_Session_Container'] variable - it was/is already used in Container.php and should therefore not be renamed to keep BC.

I have changed the quote() calls to quoteSmart() in DB.php. In MDB.php and MDB2.php I changed $this->type to $this->phptype and also fixed the two queries.

The Session diff didn't change, the others can be found here:
http://www.zilleon.de/PEAR/HTTP/Session/Container/DB.diff.txt
http://www.zilleon.de/PEAR/HTTP/Session/Container/MDB.diff.txt
http://www.zilleon.de/PEAR/HTTP/Session/Container/MDB2.diff.txt

Best regards, Torsten

[2005-04-26 09:58 UTC] mbartel at netp dot de

Hallo Torsten,
bei error_reporting = E_ALL bekommt man folgende Meldung:
Undefined variable: gcProbability in ..pear\HTTP\Session.php on line 619
Ist gcProbability an dieser Stelle überhaupt notwendig? Kann ich session.gc_maxlifetime nur setzen, wenn diese Variable gesetzt ist?

[2005-04-26 17:38 UTC] roehr at zilleon dot com

Thanks for spotting this. The diff has been updated:
http://www.zilleon.de/PEAR/HTTP/Session.diff.txt

Regards, Torsten Roehr

[2005-09-02 21:14 UTC] torsten dot roehr at gmx dot de

This bug has been fixed in CVS.

If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.