Bug #456

Admin_Perm_Container_DB_Complex::addUserToGroup

Details

Submitted	2003-12-18 21:08 UTC
From	jmikola at burgiss dot com
Assigned	lsmith
Status	Closed
Package	LiveUser
PHP Version	Irrelevant
OS	ANY
Roadmaps	(Not assigned)

Comments

[2003-12-18 21:08 UTC] jmikola at burgiss dot com

Description:
------------
(referenced from dec-18-2003 cvs, bug report opened per alimbourg's request)

admin_perm_container_db_complex::addUserToGroup, line 428:

a call to _getPermUserId() is embedded within the insert query's construction. i was just wondering if it was the author's intention for a bad auth_id parameter to break the insert query when _getPermUserId() returns null on a mismatch. as it stands, a db_error would indeed be returned (sending null as a value for a primary key component), which follows spec, although an unmatched auth_id seems like a userland error that could easily be caught without generating a db_error (perhaps returning false or something).

[2004-01-07 11:26 UTC] corwin42 at gmx dot de

Why are the functions addUserToGroup and removeUserFromGroup in the DB_Complex class? I think they need to be the same functions as in DB_Medium. Or am I wrong?