Bug #4582

error handling

Details

Request #4582	error handling
Submitted	2005-06-13 19:19 UTC
From	michael dot caplan at lechateau dot ca
Assigned	danielc
Status	Closed
Package	XML_RPC
PHP Version	5.0.4
OS	irrelevant
Roadmaps	(Not assigned)

Comments

[2005-06-13 19:19 UTC] michael dot caplan at lechateau dot ca

Description:
------------
XML_RPC_Client defined $errstring, however, $errstr is used throughout. Also, XML_RPC_Client::sendPayloadHTTP10() could be a little more verbose in connection errors. Below is a proposed patch.

Reproduce code:
---------------
595c595
< var $errstring = '';
---
> var $errstr = '';
817,819c817,821
< $this->raiseError('Connection to proxy server '
< . $this->proxy . ':' . $this->proxy_port
< . ' failed. ' . $this->errstr,
---
> $this->errstr = 'Connection to proxy server '
> . $this->proxy . ':' . $this->proxy_port
> . ' failed. ' . $this->errstr;
>
> $this->raiseError($this->errstr,
823,825c825,829
< $this->raiseError('Connection to RPC server '
< . $server . ':' . $port
< . ' failed. ' . $this->errstr,
---
> $this->errstr = 'Connection to RPC server '
> . $server . ':' . $port
> . ' failed. ' . $this->errstr;
>
> $this->raiseError($this->errstr,

[2005-06-13 19:52 UTC] michael dot caplan at lechateau dot ca

good enough. Thanks! Nice work cleaning up the class. 1.3.0 seems like a really nice step forward.