Bug #4788

syntax error in version_compare + new: implementation of is_scalar!!!

Details

Submitted	2005-07-11 15:24 UTC
From	giunta dot gaetano at sea-aeroportimilano dot it
Assigned	aidan
Status	Closed
Package	PHP_Compat
PHP Version	4.3.11
OS	irrelevant
Roadmaps	(Not assigned)

Comments

[2005-07-11 15:24 UTC] giunta dot gaetano at sea-aeroportimilano dot it

Description:
------------
1 - abogus ']' char is present on line 107: code is broken

2 - function docc lie about minimum required php version: it makes use of is_scalar, which was added in PHP 4.0.5, not PHP 4.0.0

on second toughts, is_scalar could be a target for another addition to compat package...

Bye
Gaetano

[2005-07-11 16:02 UTC] giunta dot gaetano at sea-aeroportimilano dot it

BTW: is_scalar is used in many other functions of php_compat besides version_compare, e.g. array_key_exists

[2005-07-11 16:13 UTC] giunta dot gaetano at sea-aeroportimilano dot it

Here's da code for is_scalar

<?php
// +----------------------------------------------------------------------+
// | PHP Version 4 |
// +----------------------------------------------------------------------+
// | Copyright (c) 1997-2004 The PHP Group |
// +----------------------------------------------------------------------+
// | This source file is subject to version 3.0 of the PHP license, |
// | that is bundled with this package in the file LICENSE, and is |
// | available at through the world-wide-web at |
// | http://www.php.net/license/3_0.txt. |
// | If you did not receive a copy of the PHP license and are unable to |
// | obtain it through the world-wide-web, please send a note to |
// | license@php.net so we can mail you a copy immediately. |
// +----------------------------------------------------------------------+
//
// $Id: $

/**
* Replace is_scalar()
*
* @category PHP
* @package PHP_Compat
* @link http://php.net/function.is_scalar
* @author Gaetano Giunta
* @version $Revision: 1.1 $
* @since PHP 4.0.5
* @require PHP 4 (is_bool)
*/
if (!function_exists('is_scalar')) {
function is_scalar($val)
{
// Check input
return (is_bool($val) || is_int($val) || is_float($val) || is_string($val));
}
}

That's all folks...