Bug #5654

'Passing by reference' notice under PHP 4.4.0

Details

Submitted	2005-10-11 10:46 UTC
From	vladimir dot shapiro at michel-consulting dot de
Assigned	farell
Status	Closed
Package	HTML_Progress
PHP Version	4.4.0
OS	Unix
Roadmaps	(Not assigned)

Comments

[2005-10-11 10:46 UTC] vladimir dot shapiro at michel-consulting dot de

Description:
------------
After upgrade my PHP up to 4.4.0 I get the follwoing notice

Notice: Only variables should be assigned by reference in /usr/lib/php/HTML/Progress.php on line 1118

Removing the passing by reference on the line 1118 seems to solve the problem. Anyway there are a lot of similar parts of code that should be checked.

More on topic "Memory corruptions with references":
http://www.php.net/release_4_4_0.php

Test script:
---------------
<?php
require_once 'HTML/Progress.php';

$progress_bar = new HTML_Progress();
$progress_bar->setAnimSpeed(100);
$progress_bar->setIncrement(10);
$progress_bar->setBorderPainted(true);
$progress_bar->setStringPainted(true);

$GLOBALS['extraCSS'] = $progress_bar->getStyle();
$GLOBALS['extraJS'] = $progress_bar->getScript();
?>

Expected result:
----------------
no notice (E_ALL safe output)

Actual result:
--------------
Notice: Only variables should be assigned by reference in /usr/lib/php/HTML/Progress.php on line 1118

[2005-10-17 08:16 UTC] vladimir dot shapiro at michel-consulting dot de

We've fixed it manually. Thank you for your support in next release.