Home » File Formats » File_XSPF » Bug #6649
Track annotations are left out
Details
| Submitted | 2006-02-01 00:21 UTC |
|---|---|
| From | norman at dontblink dot com |
| Assigned | djg |
| Status | Closed |
| Package | File_XSPF |
| PHP Version | Irrelevant |
| OS | any |
| Roadmaps | (Not assigned) |
Comments
[2006-02-01 00:21 UTC] norman at dontblink dot com
Description:
------------
For some reason track annotations are skipped in the XML
output. Am I missing something? Perhaps. In case not,
though, here's a patch that adds the track annoation to the
file.
Without this, your track names all show up as "Undefined"
with XSPF Web Music Player (http://
musicplayer.sourceforge.net/)
*** /usr/local/lib/php/File/XSPF/Track.php Tue Jan 31
21:16:11 2006
--- /tmp/Track.php Tue Jan 31 21:16:51 2006
***************
*** 605,610 ****
--- 605,613 ----
if ($this->_album) {
$track->addChild('album', $this->getAlbum());
}
+ if ($this->_annotation) {
+ $track->addChild('annotation', $this-
>getAnnotation());
+ }
if ($this->_creator) {
$track->addChild('creator', $this->getCreator
());
}
***************
*** 648,651 ****
}
}
}
! ?>
\ No newline at end of file
--- 651,654 ----
}
}
}
! ?>
[2006-02-01 10:08 UTC] djg at php dot net
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.