Bug #6729

Veteran's Day wrong

Details

Submitted	2006-02-08 16:58 UTC
From	seth at pricepages dot org
Assigned	luckec
Status	Closed
Package	Date_Holidays
PHP Version	Irrelevant
OS	Mac
Roadmaps	(Not assigned)

Comments

[2006-02-08 16:58 UTC] seth at pricepages dot org

Description:
------------
Veteran's day is marked incorrectly in the calendar. It
looks like the code was copy-pasted, but someone forgot to
change most of it.

Here are the lines for Veteran's Day in Date/Holidays/
Driver/USA.php:
$columbusDay = $this->_calcNthMondayInMonth(11,2);
$this->_addHoliday('veteransDay',$columbusDay,'Veteran\'s
Day');

(Which looks suspiciously like Columbus Day...)

Veteran's Day should be the 11th day in November.

While I'm here, I'll mention that the Christmas Day variable
is $tday, which is a little odd... Maybe $cday would be more
appropriate, but no harm done.

[2006-02-13 02:25 UTC] seth at pricepages dot org

Veteran's Day should be the 11th day in Nov, but you have it
placed at the 2nd monday at Nov.

http://en.wikipedia.org/wiki/Veterans_Day