Bug #6966

Is 'action' validated properly?

Details

Submitted	2006-02-28 19:59 UTC
From	awbacker at gmail dot com
Status	Bogus
Package	Payment_Process
PHP Version	5.1.2
OS	linux
Roadmaps	(Not assigned)

Comments

[2006-02-28 19:59 UTC] awbacker at gmail dot com

Description:
------------
I am getting errors about validation failing on the 'action' field. I appears that it should be using the _isDefinedConst() function to validate, not isset(). Especially since the function seems to mention the action field in the comments!

I think I am missing something, since this seems to break everything and I expect that it would have been reported. I am using this approximatly as shown below :

Test script:
---------------
$ps = Payment_Process::factory('Dummy');
... set values ...
$ps->action = PAYMENT_PROCESS_ACTION_AUTHONLY;
... create & validate card ..
$result = $ps->process();
// boom : Validation of field "action" failed.

[2006-02-28 20:00 UTC] zim at zim dot zim

Why does pear validate bug reports against bugs from *other* projects? Many unflattering words to describe this come to mind.

[2006-02-28 23:40 UTC] awbacker at gmail dot com

Ok, pear's system officially sucks. This is the 2nd time it's lost my comments. I give up.

Thanks for the info. It is bad that Dummy is broken, since now I need to dev against the real gateway.

I am willing to contribute changes I make to the dummy, if I become familiar enough with the code. Also, I have not been able to find any documentation on the project, and the home page it points to is 404.