Home » PEAR » PEAR_Command_Packaging » Bug #6971
Create deps on php-[ext]
Details
| Request #6971 | Create deps on php-[ext] |
|---|---|
| Submitted | 2006-03-01 11:00 UTC |
| From | timj at php dot net |
| Assigned | timj |
| Status | Closed |
| Package | PEAR_Command_Packaging |
| PHP Version | 4.4.2 |
| Roadmaps | (Not assigned) |
Comments
[2006-03-01 11:00 UTC] timj at php dot net
Description:
------------
The current code does not create any RPM dependencies on PHP extensions or modules (e.g. xml, pcre etc.). Such deps would depend on downstream packaging (e.g. see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173804) so it would be good to be configurable in the same way as the --rpm-depname and --rpm-pkgname options.
See also Problem 5 of:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176725
Part of this patch does the trick:
https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=122656
Test script:
---------------
pear make-rpm-spec Crypt_CHAP-1.0.0.tgz
grep ^Requires PEAR\:\:Crypt_CHAP-1.0.0.spec
Expected result:
----------------
Requires: php-mhash, php-mcrypt
Actual result:
--------------
[nothing]
[2006-03-02 16:37 UTC] glen at delfi dot ee
i've solved similiar problem in makerpm command. but i
believe these can be integrated into this package too.
http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/php-pear-PEAR-rpmvars.patch
the patch is actually meta patch, ie it solves various
issues
i list the previous work regardin spec packaging also here
(some of them already obsolete):
http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/php-pear-PEAR-rpmpkgname.patch
http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/php-pear-PEAR-specfile.patch
[2006-04-15 01:41 UTC] timj at php dot net
OK, I've fixed this bug in CVS. Elan, I've also added in one way or another most of the changes from your own patches, at least the ones that are appropriate to pull upstream. Please take a look at the cvs logs and have a play with this new version. You should find that your distro-specific patches are now much smaller and simpler. After that, if there's anything that's outstanding that can be pushed upstream (e.g. your "optional deps" stuff; I didn't do anything with that so far), please file new bugs here as appropriate. (Patches appreciated :-)