Bug #7845

mbstring and other fixes

Details

Submitted	2006-06-09 05:40 UTC
From	l dot kneschke at metaways dot de
Assigned	amistry
Status	Closed
Package	Net_Sieve
PHP Version	5.0.4
OS	Linux
Roadmaps	(Not assigned)

Comments

[2006-06-09 05:40 UTC] l dot kneschke at metaways dot de

Description:
------------
Net_Sieve fails with mbstring overload activated for strlen and characters outside the us-ascii charset, because it calculates the wrong string lenght. A fix is inlcuded.

Net_Sieve also fails when reading a script from a sieve server and not closing the connection after. The read function only reads the sieve script, but does not read the pending OK from the imap server. If you try to read the script again you get back a OK only. A fix for this problem is inlcuded too.

My modification got tested against the sieve implementation from cyrus imap server and dbmail imap server(which is using libsieve).

Test script:
---------------
The patch is available at http://lars.kneschke.de/Net_Sieve-1.1.3-patch

[2006-08-16 08:26 UTC] amistry at php dot net

I think I've fixed this in the CVS. Would you please check the CVS version? Also if you can add a testcase against SieveTest.php for you script(s) that revealed this bug. Email me or link to the diff and sieve script. Thanks.

[2006-12-22 20:45 UTC] amistry at php dot net

This commit broke CRAM/DIGEST authentication. Technically it still worked, but it introduced a timeout while waiting for an OK during negotiation Bug #9273. I've fixed that problem. Would you test the CVS version to make sure the script problem hasn't recurred for you.
Thanks.