Home » Structures » Structures_DataGrid_Renderer_HTMLTable » Bug #8172

[2006-07-10 09:43 UTC] gbcreation at free dot fr

Description:
------------
Line 374, there is a space between the label and the sort
icon :
$str = "<a href=\"$url\">$label $icon</a>";
When there are many columns, the header of the sorted
column wraps, and the sort icon is on a new line under the
label. using   in the sortIconASC and sortIconDESC
options changes nothing of course :-)
I think it's better to let the developer manages this
behavior by using normal space or non-breaking space in
the sortIconASC and sortIconDESC options. Patch is to
remove the space between the $label and $icon variables :

$str = "<a href=\"$url\">$label$icon</a>";

[2006-08-04 21:59 UTC] olivierg at php dot net

I don't like the idea of adding an option for such a tiny detail.

I've just removed the space in CVS, as Gontran proposed. It might cause minor layout BC breaks, nothing really important.

I agree it's not our job to insert such spaces.

This bug is closed. Feel free to reopen it if you disagree with the fix.