Home » HTML » HTML_QuickForm » Bug #8329

[2006-07-31 13:46 UTC] yoghoyogho at fastmail dot fm

Description:
------------
See http://cvs.php.net/viewvc.cgi/pear/HTML_QuickForm/QuickForm/file.php?revision=1.20&view=markup

There's an unnecessary if-else block in the method moveUploadedFile. The return value is a boolean, based on a boolean value from move_uploaded_file.

Test script:
---------------
I would replace:

if (move_uploaded_file($this->_value['tmp_name'], $dest . $fileName)) {
return true;
} else {
return false;
}

with:
return move_uploaded_file($this->_value['tmp_name'], $dest . $fileName);

See also http://www.php.net/move_uploaded_file for the possible return values (they're all boolean)