Bug #8445

Typo and unreachable code

Details

Request #8445	Typo and unreachable code
Submitted	2006-08-15 12:52 UTC
From	stefanvalouch at googlemail dot com
Assigned	jystewart
Status	Closed
Package	XML_Feed_Parser
PHP Version	5.1.4
OS	Debian/GNU Linux Etch
Roadmaps	(Not assigned)

Comments

[2006-08-15 12:52 UTC] stefanvalouch at googlemail dot com

Description:
------------
Hi, there is a typo in XML/Feed/Parser/Type.php
Line: 53:
* Peoxy to allow use of element names as method names
should be:
* Proxy to allow use of element names as method names

then, there is unreachable code in the same file, function combineBases() line 158:
[...]
return $base . $link;
}
return $combinedBase; //<--- this return cannever be reached...
}

File: XML/Feed/Parser.php line :
function getEntryById()
[...]
return $this->feed->getEntryById($id);

return false; //<-- unreachable
[...]

HTH
Stefan

[2006-08-15 13:02 UTC] jystewart at php dot net

This bug has been fixed in CVS.

If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.