Bug #8654

Patch 8489 opens new issue with the class constructor of Entry

Details

Submitted	2006-09-07 14:31 UTC
From	b dot hallinger at skyforcesystems dot de
Assigned	beni
Status	Closed
Package	Net_LDAP
PHP Version	4.4.4
Roadmaps	(Not assigned)

Comments

[2006-09-07 14:31 UTC] b dot hallinger at skyforcesystems dot de

Description:
------------
The patch for Bug #8489 opens a new "issue".

It may lead to problems with the current interfaces, beacause the parameter $ldap of the Entry class is no longer optional.

Firstly, the $ldap paremeter needs to check if NULL is passed, so it will remain possible to create a "empty" entry object.
Secondly, the $ldap parameter should go to the beginning of the parameter list, beause optional parameters are expected at the end.

Test script:
---------------
function Net_LDAP_Entry($entry = null, &$ldap)

should be changed in

function Net_LDAP_Entry(&$ldap, $entry = null)

All methods that use this interface need to be changed to the new behavior.

Btw, the comment of the constructor is outdated.