Bug #8761

Getting form's "action" attribute fails in HTML_AJAX.js formSubmit

Details

Submitted	2006-09-21 17:25 UTC
From	alex dot chumak at gmail dot com
Assigned	auroraeosrose
Status	Closed
Package	HTML_AJAX
PHP Version	5.1.6
OS	OS X + Safari
Roadmaps	0.5.1

Comments

[2006-09-21 17:25 UTC] alex dot chumak at gmail dot com

Description:
------------
Using the 0.5 beta HTML_AJAX had a problem with Safari when
formSubmit()'ting.

traced to this line in /usr/share/pear/data/HTML_AJAX/js/
HTML_AJAX.js:

var action = form.attributes['action'].value;

changed it to:

var action = form.getAttribute('action');

and everything worked fine after that

[2006-09-21 17:37 UTC] jeichorn at php dot net

can someone write a quick test for this so we can get cross browser testing done. I'm pretty sure we switched away from form.getAttribute because it didn't work right in IE 6.

[2006-09-21 18:23 UTC] alex dot chumak at gmail dot com

i have only changed it to that because you are in fact using
form.getAttribute('method') a few lines below the line that
gave me trouble, So instead of having 2 various ways of doing
the same i switched the first to use the 2nd format.

if it doesnt work right in IE, the second call would give you
trouble anyway... unless there is something specific to
"action" attribute and IE.

[2006-09-21 19:22 UTC] jeichorn at php dot net

If i remember correctly we changed things from getAttribute for action because it didn't work right in IE when you had a form element with the name of action or something screwy like that.

We should be able to get something that works everywhere its just a matter of doing enough testing to find out what that combination of things is.

[2006-11-21 15:12 UTC] auroraeosrose at php dot net

Should be fixed in SVN