Home » Networking » Net_IMAP » Bug #9598

[2006-12-11 11:18 UTC] l dot kneschke at metaways dot de

Description:
------------
Hello!

This patch contains some major improvements, to be able to replace the php-imap extension completely.

I fixed following 2 major bugs:

Quoted strings can contain a \ . They need to be escaped properly. I stumbled about this problem, while connecting to a Domino IMAP server which uses a backslash as delimiter.

I also made the class mbstring aware. If mbstring overloading is activated, you will get wrong results when using strlen in some cases(when the string contains some utf chars for example).

Where possible i made all functions accept UID's or MSGID's while keeping backward compatibility.

I fixed some documentation errors and still need to update the documentation for my new functions.

I added support for fetching the bodystructure.
I added support for fetching the namespace.
I added support for fetching subparts and the headers of subparts.
I added support for fetching the mailbos status at once(getStatus).

And something more maybe. :-)

The class is in real life tested already. FeLaMiMail, the imap client from eGroupWare, is now based on this class.
The class got tested against DBMail and Cyrus so far.

[2006-12-11 11:25 UTC] l dot kneschke at metaways dot de

Attaching files does not seem to be the preferred way to submit patches. :-)

I have made them available online at:

http://lars.kneschke.de/Net_IMAP-patches.tar.gz

Lars

[2006-12-11 15:43 UTC] amistry at php dot net

Thanks, I'll review and commit it to the CVS this week. As you may have noticed I haven't done a release since I've take over maintainership. The main reason is that I've lacked the time to write a solid set of unit tests (PHPUnit2). It seems that you've put a lot of work into fixing Net_IMAP. If you have the time I'd welcome any unit tests too. I can help you get start if you're interested.
If you don't see your patches committed to the CVS within 7 days, please remind me.
Thanks.

[2006-12-11 15:54 UTC] amistry at php dot net

Committed to the CVS. I just quickly browsed the code and it looked sane so I just committed it. Please test it just to verify what I committed was correct. Thanks.

[2006-12-11 17:18 UTC] l dot kneschke at metaways dot net

Hello!

I'll check out from CVS later this day and check if it is still working.

[2006-12-18 10:00 UTC] l dot kneschke at metaways dot net

The commit is correct. I'll open another bug report for another patch.

[2006-12-18 15:24 UTC] amistry at php dot net

This bug has been fixed in CVS.

If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.