Bug #9929

Echoing proto errors and others to the HTML Stream

Details

Request #9929	Echoing proto errors and others to the HTML Stream
Submitted	2007-01-23 17:48 UTC
From	joseph dot valerio at yale dot edu
Assigned	hudeldudel
Status	Closed
Package	Net_IMAP
PHP Version	4.3.11
OS	linux
Roadmaps	(Not assigned)

Comments

[2007-01-23 17:48 UTC] joseph dot valerio at yale dot edu

Description:
------------
There are echos to the HTML Stream in IMAPProtocol.php. The most troubling one is the _prot_error. Since there are missing parts to the IMAP implementation, everytime you come across something not understood, and error is thrown, and echoed out to the HTML Print Stream.

Test script:
---------------
Any Call to my Cyrus Server...

Expected result:
----------------
No echo... use error_log()... or PEAR:LOG

Actual result:
--------------
N/A

[2007-01-24 00:24 UTC] hudeldudel at php dot net

Hi,

there have have been made many fixes since the last stable release.
Please try the current beta.
Also try current CVS version if you are using a very new version of cyrus supporting the NOMODSEQ response.

As there are no real informations about the error messages, this is _no_ usable bug report.

I've changed the bug type to Feature Request because of its main topic. I will review it within the next days as this needs to be done in a way that also considers cli applications.

regards

hudeldudel

[2007-01-24 14:28 UTC] joseph dot valerio at yale dot edu

hudeldudel,

We are using a more recent version of Cyrus supporting NOMODSEQ, and this is the source of the _prot_error, but that is besides the point. If you want this code to be considered production level, you must NOT echo anything. Use error_log or PEAR::Log package to put these errors where they belong, a log file, not the HTML Stream... There are echos in the beta version and the CVS head. IMHO it is an easy fix and a quick win. I have already fixed our local version, but would rather not have to track and support a patched version. I worry about some other error happening that I have not accounted for, and the errors(May not even matter to my users) echoing up on their web page.

[2007-01-30 00:51 UTC] hudeldudel at php dot net

I agree with you that this class should NOT echo anything by default.
Now there is a quick fix at CVS but I will have to put more work on this.

Regarding your problems with MODSEQ, I've just installed a current unstable version from cyrus for testing.

hudeldudel