Home » HTML » Pager » Bug #9946

[2007-01-25 17:31 UTC] gurbani at gmail dot com

Description:
------------
Hi Lorenzo,

I think I found a tiny bug in Pager.
Basically, this is the case:
- if the minimum limit in Pager is set e.g. to 25
- you only have e.g. 5 values
- you want to have a Select Box
- you set e.g. 'showAllText' => "All"

THEN

- The select box is returned with no option values, i.e. an empty Select Box

I've put the following fix at the end of function getPerPageSelectBox in HtmlWidgets.php. It seems to work for me.
Does it make sense to you? If so, can the library be updated with this fix?

Thanks
Prem

Test script:
---------------
(end of function getPerPageSelectBox, HtmlWidgets.php)

[..........]
$tmp .= $this->pager->_showAllText;
}
$tmp .= '</option>';
} else if ($showAllData) {
$tmp .= '<option value="'.$this->pager->_totalItems.'" selected="selected">';

if (empty($this->pager->_showAllText)) {
$tmp .= str_replace('%d', $this->pager->_totalItems, $optionText);
} else {
$tmp .= $this->pager->_showAllText;
}
$tmp .= '</option>';
}
$tmp .= '</select>';
return $tmp;
}